fix(penpal): propagate git log errors and show retry in timeline - #537
Merged
Conversation
…ding fails When loading commits fails (network error, git command failure, etc.), display a load-error row at the bottom of the timeline with a Retry button. For the initial-load case where no cached data exists, add a retry button next to the error message. The standalone revalidation-error div is removed since errors now render inside the timeline itself. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…swallowing them When fetching commits for a remote branch, build_branch_timeline() used `if let Ok(output)` to silently ignore git log failures (e.g. network errors when offline). This caused the frontend to receive an empty but valid BranchTimeline, making the project appear empty with no error UI. Replace the `if let Ok(output)` pattern with `.map_err(...)?` so that git log failures are propagated as errors to the caller. The frontend's existing error handling (added in the previous commit) will now correctly display the error state with a retry button. The merge-base call still uses graceful fallback since it's less critical and has a reasonable default (the raw base branch ref).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git logerrors for remote branches instead of silently swallowing them, so the UI can surface meaningful feedbackload-errorrow type toTimelineRowand wire retry callbacks throughBranchTimelineTest plan
🤖 Generated with Claude Code