Conversation
Move the nix crate to a [target.'cfg(unix)'.dependencies] section in Cargo.toml and gate all Unix-specific code paths in driver.rs behind #[cfg(unix)] attributes: - nix imports (signal, Pid) - process_group(0) call for remote proxies - SIGINT-to-process-group logic in graceful_stop() On non-Unix platforms the gated blocks compile out entirely, and graceful_stop falls through to child.kill() which is the existing fallback behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nixcrate dependency conditional on Unix platforms viacfg(unix)inCargo.tomlnix::sys::signal,nix::unistd::Pid) and usage sites (process_group,graceful_stop) with#[cfg(unix)]attributesacp-clientcrate to compile on non-Unix platforms (e.g., Windows)Test plan
🤖 Generated with Claude Code