Skip to content

fix(staged): show code review button when commit session is in progress - #558

Merged
matt2e merged 2 commits into
mainfrom
code-review-should-be-visible-if-commit-happening
Mar 31, 2026
Merged

fix(staged): show code review button when commit session is in progress#558
matt2e merged 2 commits into
mainfrom
code-review-should-be-visible-if-commit-happening

Conversation

@matt2e

@matt2e matt2e commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Show the code review button when a commit session is pending, queued, or running, even if there are no code changes yet on the branch
  • Refactor hasPendingOrActiveCommitSession from a private method to a $derived property (hasCommitSessionInProgress) so it can be referenced in the template

Test plan

  • Start a commit session on a branch with no prior code changes and verify the code review button is visible
  • Verify the code review button still appears normally when there are code changes
  • Verify auto-review adoption still correctly checks for in-progress commit sessions

🤖 Generated with Claude Code

matt2e and others added 2 commits March 31, 2026 16:24
The "New Code Review" button was only visible when finalized commits
existed. Now it also appears when a commit session is pending, queued,
or running, since there will be code changes to review once it completes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The private method was a one-liner delegating to hasCommitSessionInProgress
with only a single call site, so inline it to reduce indirection.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@matt2e
matt2e requested review from baxen and wesbillman as code owners March 31, 2026 05:33
@matt2e
matt2e merged commit 53a9a54 into main Mar 31, 2026
4 checks passed
@matt2e
matt2e deleted the code-review-should-be-visible-if-commit-happening branch March 31, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant