Skip to content

fix(staged): show 'Looking for changes' and fix delayed commits after project-from-PR creation - #635

Merged
matt2e merged 2 commits into
mainfrom
project-from-pr-delayed-commits
Apr 15, 2026
Merged

fix(staged): show 'Looking for changes' and fix delayed commits after project-from-PR creation#635
matt2e merged 2 commits into
mainfrom
project-from-pr-delayed-commits

Conversation

@matt2e

@matt2e matt2e commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Show "Looking for changes…" status during the gap between worktree provisioning completing and the timeline loading, instead of briefly showing an empty branch card with enlarged action buttons
  • Ensure timeline data is fresh by invalidating caches when worktree setup completes and before reloading after session completion
  • Log git errors in timeline construction instead of silently swallowing them with unwrap_or_default()
  • Refactor provisioningLabel/provisioningDetail to derive from isSettingUp/isProvisioning computed values instead of duplicating conditions

Test plan

  • Create a project from a PR and verify "Looking for changes…" appears during setup
  • Verify commits appear correctly once the timeline loads
  • Verify no empty state / enlarged buttons flash during provisioning

🤖 Generated with Claude Code

matt2e and others added 2 commits April 15, 2026 16:56
… project-from-PR creation

When creating a project from a PR, users saw an empty branch card with
enlarged action buttons before commits eventually appeared. This fixes
two issues:

1. Show "Looking for changes…" status during the gap between worktree
   provisioning completing and the timeline loading, instead of briefly
   showing nothing or the empty-state enlarged buttons.

2. Ensure timeline data is fresh by invalidating caches when worktree
   setup completes and before reloading after session completion.

Also logs git errors in timeline construction instead of silently
swallowing them with unwrap_or_default().

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…Provisioning

Resolve code review feedback on 8685c55:

1. provisioningLabel and provisioningDetail now derive from the
   isSettingUp and isProvisioning computed values instead of
   duplicating their raw conditions, keeping a single source of truth.

2. Rename the isProvisioning prop on BranchCardActionsBar to
   isSettingUp to match what is actually passed — the broader flag
   that covers both provisioning and the worktree-ready-but-timeline-
   not-loaded gap.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@matt2e
matt2e requested review from baxen and wesbillman as code owners April 15, 2026 07:07
@matt2e
matt2e merged commit b8a3747 into main Apr 15, 2026
5 checks passed
@matt2e
matt2e deleted the project-from-pr-delayed-commits branch April 15, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant