fix: pin subtitle-badge and action-button icons with translateZ(0) - #803
Merged
Conversation
The #782 fix only pinned the left marker icon (.timeline-icon) onto its own compositing layer. The subtitle review badges (.meta-badge) and the hover-revealed action-button icons (.timeline-actions svg) were left unpinned, so the row's hover background-color transition re-rasterized them and re-snapped them to fractional device pixels — the residual ~1px jiggle. Extend the same per-element layer hint to those two sites, keeping it on the small elements to preserve #775's per-row memory win. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops timeline-row icons from jiggling/re-snapping to fractional pixels during hover transitions by promoting them onto their own compositing layers.
Changes
.subtitle-badge): addtransform: translateZ(0)so its icon stays put during the row's hoverbackground-colortransition (same rationale as.timeline-icon)..timeline-actions :global(svg)): addtransform: translateZ(0)so they don't jiggle during the container's opacity fade or the Button'stransition-allon hover.