chore: bump rust toolchain to 1.96.1 - #842
Merged
Merged
Conversation
Pins the workspace to the latest stable Rust (1.96.1, released 2026-06-30), up from 1.95.0. 1.96.1 is a point release over 1.96.0 that patches three libssh2 CVEs bundled with Cargo (CVE-2025-15661, CVE-2026-55199, CVE-2026-55200), fixes a MIR-optimization miscompilation, and restores missing retries/timeouts in Cargo's HTTP client. Verified with cargo check --workspace under 1.96.1. Signed-off-by: Matt Toohey <contact@matttoohey.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de7c3ed368
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The Tauri app CI workflows (differ, penpal, staged) build Rust from their app subdirectories, where rustup resolves the workspace-root rust-toolchain.toml. But none of those workflows listed rust-toolchain.toml in its pull_request/push path filters, so a toolchain bump made in isolation only triggered Crates CI. A new compiler could merge without ever building or linting the apps, deferring any app-specific build/clippy failures to the next unrelated app change or a release. Add rust-toolchain.toml to the path filters of all three app CI workflows, matching the filter that crates-ci.yml already declares, so toolchain bumps exercise the app checks too. Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned Rust toolchain from 1.96.0 to 1.96.1 in
rust-toolchain.toml.Changes
rust-toolchain.tomlto pin Rust 1.96.1.🤖 Generated with Claude Code