fix(staged): add missing table CSS to chat markdown - #843
Merged
Conversation
The chat transcript's .markdown-content block styled every markdown element except tables, so tables rendered with browser defaults (no borders, cramped layout) while the note dialog styled them correctly. Both views render identical HTML from the shared renderMarkdown, so port the three table rules from NoteModal into SessionModal: table (border-collapse, full width, margin), th/td (borders, padding, left-align), and th (header background, bold). Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Markdown tables rendered in the chat view of the session modal were displaying without any styling, making them effectively invisible/unreadable. This adds the missing table CSS to
SessionModal.svelteso tables render with borders, padding, and a styled header row.Changes
:globaltable styles to.markdown-content:table: collapsed borders, full width, vertical marginth/td: subtle border, padding, left-aligned textth: primary background and bold text for header cellsTesting
Styling-only change; verified via the CI checks that ran on push (crates-fmt, crates-test, crates-lint, differ-ci, staged-ci all passing).