-
Notifications
You must be signed in to change notification settings - Fork 22
feat(staged): theme Pikchr diagram colors to match the active theme #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| import { createAdaptiveTheme, themeToVarMap } from './theme'; | ||
|
|
||
| describe('createAdaptiveTheme', () => { | ||
| it('exposes a soft themed Pikchr palette for dark chrome', () => { | ||
| const vars = themeToVarMap( | ||
| createAdaptiveTheme('#27212e', '#ffffff', '#91889b', { | ||
| added: '#3fb950', | ||
| deleted: '#f85149', | ||
| modified: '#d29922', | ||
| }) | ||
| ); | ||
|
|
||
| expect(vars['--diagram-canvas-bg']).toBe('#f2edf8'); | ||
| expect(vars['--pikchr-ink']).toBe('#241a2f'); | ||
| expect(vars['--pikchr-surface']).toBe('#fffaff'); | ||
| expect(vars['--pikchr-muted']).toBe('#74677f'); | ||
| expect(vars['--pikchr-red']).toBe('#ec91a0'); | ||
| expect(vars['--pikchr-green']).toBe('#80cd99'); | ||
| expect(vars['--pikchr-blue']).toBe('#8bbaed'); | ||
| expect(vars['--pikchr-yellow']).toBe('#ecd285'); | ||
| expect(vars['--pikchr-orange']).toBe('#ebae7f'); | ||
| expect(vars['--pikchr-yellow']).not.toBe(vars['--pikchr-orange']); | ||
| }); | ||
|
|
||
| it('uses a quiet light Pikchr palette for light chrome', () => { | ||
| const vars = themeToVarMap( | ||
| createAdaptiveTheme('#ffffff', '#24292e', '#6e7781', { | ||
| added: '#28a745', | ||
| deleted: '#d73a49', | ||
| modified: '#2188ff', | ||
| }) | ||
| ); | ||
|
|
||
| expect(vars['--diagram-canvas-bg']).toBe('#fbf8ff'); | ||
| expect(vars['--pikchr-surface']).toBe('#ffffff'); | ||
| expect(vars['--pikchr-ink']).toBe('#24292e'); | ||
| expect(vars['--pikchr-blue']).toBe('#81abdd'); | ||
| expect(vars['--pikchr-orange']).toBe('#da9a6f'); | ||
| expect(vars['--pikchr-yellow']).not.toBe(vars['--pikchr-orange']); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a diagram uses Pikchr's decimal or shorter C-style numeric color literals (for example
color 0,color 255, orfill 16777215), this regex does not add the rendered#000000/#0000ff/#ffffffkey topreservedColors, sothemePikchrColorlater rewrites those explicit author colors to theme variables. Pikchr color expressions are 24-bit numeric values, not only six-digit0xRRGGBBconstants, so this breaks the intended preservation for supported numeric color syntax whenever the chosen value is one of the mapped colors.Useful? React with 👍 / 👎.