feat(staged): enable web PR polling transport - #850
Conversation
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7eb71e31c5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| // TODO(web): restore HTTP transport from the `mobile-web` branch | ||
| throw new Error(`[transport] Web mode is not available in this build (command: ${command})`); | ||
| const response = await fetch(`/api/invoke/${encodeURIComponent(command)}`, { |
There was a problem hiding this comment.
Keep web transport behind a running web server
When this runs outside Tauri, every command now POSTs to /api/invoke/..., but the backend endpoint is not actually started in this build: STAGED_WEB_SERVER still calls web_server::start, and that function only logs and returns. I also checked vite.config.ts and there is no dev proxy for /api, so browser clients hit the static/Vite server instead (404/WS failures) and PR polling cannot work. Either restore the Axum server before enabling this path or keep the previous web-mode guard.
Useful? React with 👍 / 👎.
Summary:
Tests: