Skip to content

feat(staged): enable web PR polling transport - #850

Merged
matt2e merged 3 commits into
mainfrom
add-pr-polling-to-web-client
Jul 3, 2026
Merged

feat(staged): enable web PR polling transport#850
matt2e merged 3 commits into
mainfrom
add-pr-polling-to-web-client

Conversation

@matt2e

@matt2e matt2e commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Enable web clients to receive PR polling events through the transport layer.
  • Replay PR polling hints after reconnects so polling resumes reliably.
  • Add coverage for web transport dispatch and PR polling behavior.

Tests:

  • git push pre-push hooks: crates-fmt, crates-lint, crates-test, differ-ci, staged-ci

matt2e added 3 commits July 3, 2026 10:49
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
@matt2e
matt2e requested review from baxen and wesbillman as code owners July 3, 2026 01:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7eb71e31c5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


// TODO(web): restore HTTP transport from the `mobile-web` branch
throw new Error(`[transport] Web mode is not available in this build (command: ${command})`);
const response = await fetch(`/api/invoke/${encodeURIComponent(command)}`, {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep web transport behind a running web server

When this runs outside Tauri, every command now POSTs to /api/invoke/..., but the backend endpoint is not actually started in this build: STAGED_WEB_SERVER still calls web_server::start, and that function only logs and returns. I also checked vite.config.ts and there is no dev proxy for /api, so browser clients hit the static/Vite server instead (404/WS failures) and PR polling cannot work. Either restore the Axum server before enabling this path or keep the previous web-mode guard.

Useful? React with 👍 / 👎.

@matt2e
matt2e merged commit 5c79a3d into main Jul 3, 2026
4 checks passed
@matt2e
matt2e deleted the add-pr-polling-to-web-client branch July 3, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant