feat(staged): add full-screen diagram viewer#851
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32d865ac1d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| height: 100%; | ||
| max-width: none; | ||
| max-height: none; | ||
| overflow: hidden; |
There was a problem hiding this comment.
Preserve Pikchr overflow in the full-screen viewer
When a Pikchr SVG relies on drawing outside its viewBox, the inline preview keeps that content visible via the existing .markdown-diagram-preview-pikchr .markdown-pikchr-svg { overflow: visible } rule, but the full-screen copy is rendered under .diagram-surface and this line forces the root SVG back to overflow: hidden. Opening those diagrams in the new viewer clips labels/strokes that are visible in the preview, so the modal should explicitly keep Pikchr SVG overflow visible or reuse the preview rule.
Useful? React with 👍 / 👎.
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Summary:
Tests: