Skip to content

fix(staged): adapt traffic-light spacer - #853

Merged
matt2e merged 1 commit into
mainfrom
top-left-nav-bar
Jul 3, 2026
Merged

fix(staged): adapt traffic-light spacer#853
matt2e merged 1 commit into
mainfrom
top-left-nav-bar

Conversation

@matt2e

@matt2e matt2e commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a window chrome helper for deciding when the macOS traffic-light spacer is needed.
  • Make the staged top bar spacer respond to Tauri, macOS, fullscreen, and mobile state.

Testing

  • Pre-push hooks passed during branch push.

Signed-off-by: Matt Toohey <contact@matttoohey.com>
@matt2e
matt2e requested review from baxen and wesbillman as code owners July 3, 2026 04:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 446f0fe655

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

}

export function getTrafficLightSpacerWidth(isMobile: boolean): number {
if (!isTauri || !windowChrome.isMac || isMobile || windowChrome.isFullscreen) return 0;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep traffic-light spacer on narrow macOS windows

When the macOS Tauri window is resized below the mobile breakpoint, viewport.isMobile becomes true even though the native traffic-light controls are still visible (the Tauri config allows desktop widths down to 375px with titleBarStyle: "Overlay"). This condition then collapses the spacer to 0, letting the Back button or other left actions sit underneath the traffic lights; the previous CSS still reserved 58px at this breakpoint. Only actual non-windowed/mobile contexts should remove the spacer.

Useful? React with 👍 / 👎.

@matt2e
matt2e merged commit d34df37 into main Jul 3, 2026
4 checks passed
@matt2e
matt2e deleted the top-left-nav-bar branch July 3, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant