Skip to content

feat: add split note chat pane#866

Merged
matt2e merged 8 commits into
mainfrom
chat-beside-note
Jul 7, 2026
Merged

feat: add split note chat pane#866
matt2e merged 8 commits into
mainfrom
chat-beside-note

Conversation

@matt2e

@matt2e matt2e commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a split note chat pane and wire note/session modal flows for side-by-side chat beside notes.
  • Add note freshness and indicator helpers with focused tests for stale chat behavior.
  • Polish note chat activity/status UI and hide irrelevant actions in chat-only contexts.

@matt2e
matt2e requested review from baxen and wesbillman as code owners July 7, 2026 08:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e618c719cd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1547 to +1549
{@const split = splitAtNoteIndicator(group.message.content, {
streaming: isLive && groupIdx === grouped.length - 1,
})}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Scope note truncation to note sessions

When this pane is used for plain chat/commit sessions (for example, the DiffModal SessionModal path has no linked note context), every assistant message is still passed through splitAtNoteIndicator. Any normal Markdown response containing a horizontal rule such as Intro\n---\nDetails will render only the preamble and a “Note created/updated” card, hiding the rest of the answer even though backend note extraction only runs when a note target exists. Gate this splitting on a note-writing/linked-note context instead of applying it to all assistant messages.

Useful? React with 👍 / 👎.

matt2e added 8 commits July 7, 2026 19:49
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Rename the first note activity label to "Note created", render note activity cards as passive outlined statuses, and continue the split divider through the note modal header with the copy action on the note side.

Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
@matt2e
matt2e force-pushed the chat-beside-note branch from e618c71 to 2a8991c Compare July 7, 2026 09:55
@matt2e
matt2e merged commit 6af9d5a into main Jul 7, 2026
4 checks passed
@matt2e
matt2e deleted the chat-beside-note branch July 7, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant