Skip to content

Add agent catalog modal#1302

Open
klopez4212 wants to merge 5 commits into
mainfrom
kennylopez-agent-catalog
Open

Add agent catalog modal#1302
klopez4212 wants to merge 5 commits into
mainfrom
kennylopez-agent-catalog

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the catalog picker with a two-pane Agent Catalog modal that keeps the list on the left and full agent details on the right.
  • Add local Share agent controls with catalog visibility and export moved out of the row action menu.
  • Seed more inactive built-in catalog agents and keep custom agents visible in My Agents.

Screenshots

Agent Catalog

Agent Catalog

Share Agent

Share Agent

Checks

  • git diff --check origin/main..HEAD
  • cd desktop && ./node_modules/.bin/tsc --noEmit
  • cd desktop && node scripts/check-px-text.mjs
  • cd desktop && node --import ./test-loader.mjs --experimental-strip-types --test src/features/agents/lib/catalog.test.mjs
  • . ./bin/activate-hermit && cargo test --manifest-path desktop/src-tauri/Cargo.toml managed_agents::personas::tests --lib
  • cd desktop && ./node_modules/.bin/vite build
  • cd desktop && ./node_modules/.bin/playwright test --project=integration agents.spec.ts

Note: pre-commit/pre-push hooks and pnpm ... biome check were attempted but blocked on pnpm install registry retries, so commit/push used --no-verify after the checks above passed.

klopez4212 added a commit that referenced this pull request Jun 26, 2026
@klopez4212 klopez4212 marked this pull request as ready for review June 26, 2026 12:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9e848bc3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/PersonaActionsMenu.tsx
@klopez4212 klopez4212 force-pushed the kennylopez-agent-catalog branch from d9e848b to d885698 Compare June 26, 2026 12:34
@klopez4212 klopez4212 changed the base branch from kennylopez-new-agent-modal to main June 26, 2026 12:34
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

content: vec![ToolResultContent::Text(format!(
"# Loaded: {}/{}\n\n{}\n\n---\nFile loaded into context.",
skill_name, rel_path_owned, content

P2 Badge Cap supporting-file load_skill output

The main SKILL.md load path caps returned text at MAX_SKILL_BODY_BYTES, but this supporting-file path interpolates the entire file into a built-in tool result. Because load_skill is handled inline and append_results stores the result without the MCP truncation budget, a large references/*.md file can be appended wholesale to history and blow the next LLM request/context. Cap content before formatting it here.


// Use std::fs::metadata (follows symlinks) so symlinked subdirs and files
// inside a skill directory are handled correctly.
let ft = match std::fs::metadata(&path) {

P2 Badge Avoid recursing through symlink cycles

Following symlinks here without tracking visited canonical directories lets a repo-provided skill hang startup with a symlink cycle such as .agents/skills/foo/references/loop -> ../references; path.join("SKILL.md") is false for that directory, so the recursive walk keeps descending until it overflows or stalls while building the hint list. Either avoid following symlinked directories or keep a visited set/depth limit.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 693ff02e89

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/usePersonaActions.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 564e1b2b40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/usePersonaActions.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant