feat(desktop): disambiguate duplicate agent names by owner#2019
Draft
brow wants to merge 1 commit into
Draft
Conversation
Co-authored-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Contributor
Author
|
@builderbot review |
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Agent search results now append an owner suffix only when visible agent names collide, including case-insensitive collisions. The disambiguated label appears in mention autocomplete, channel member search, and new-message recipient search, while selection still uses the agent's original name.
Accessible names match the visible labels, and the existing owner subtitle and npub fallback remain available.
Why?
Duplicate agent names were visually ambiguous across recipient surfaces. Showing
Echo (you)andeChO (outsider)at the point of selection makes ownership clear without adding noise to unique agent names or human results.How is it tested?
Build and run.
Added tests:
identity.test.mjsambiguous-agent-owner-suffix.spec.tsBefore / after
🤖 This PR was authored with an agent (Buzz: smoking gun).