Validate trigger_statuses and ai_provider on AutomatedPlanReviewer#11
Merged
HamptonMakes merged 1 commit intoFeb 23, 2026
Merged
Conversation
- Add AI_PROVIDERS constant and inclusion validation for ai_provider - Add custom validation ensuring trigger_statuses only contains values from Plan::STATUSES (brainstorm, considering, developing, live, abandoned) - Add tests for both validations Addresses issues #4 and #5 from PR #5 code review. Amp-Thread-ID: https://ampcode.com/threads/T-019c8be3-eea2-75f8-895d-a7e5da94df7d Co-authored-by: Amp <amp@ampcode.com>
HamptonMakes
deleted the
hampton/validate-trigger-statuses-and-ai-provider
branch
February 23, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issues #4 (MEDIUM) and #5 (LOW) from the code review of PR #5.
Changes
trigger_statusesvalidation (issue #4)trigger_statusesagainstPlan::STATUSES(brainstorm,considering,developing,live,abandoned)"considring"will now produce a clear validation error instead of silently breaking triggeringai_providervalidation (issue #5)AI_PROVIDERSconstant (openai,anthropic) with inclusion validationTests
All 175 tests pass.