Expand Mermaid diagrams into a lightbox on click#151
Merged
Conversation
Diagrams are constrained to the content column width, which makes larger flowcharts too small to read. Clicking a rendered diagram now opens it in a full-viewport dialog; click anywhere or press Escape to close.
jwils
marked this pull request as ready for review
July 17, 2026 19:40
Collaborator
|
Please write system specs for this! |
HamptonMakes
approved these changes
Jul 17, 2026
HamptonMakes
added a commit
that referenced
this pull request
Jul 20, 2026
…resh Prefer this branch's visibility model while genuinely adopting main's new features: - LinkPreviews/Slack unfurls (#154): adopted; context now speaks the visibility language — Private/Archived flagged, published unmarked, never "Draft". plan_og_description delegates to the same builder. - Mermaid comment anchors (#148/#149/#151): adopted; mermaid-settled re-highlighting wired into our no-tabs plan page, anchors-updated re-anchoring wired into our headless comment nav. Clicking a comment mark inside a diagram now opens its thread popover instead of the lightbox (showModal force-hides popovers). - Landing refresh + agent-instructions view (#140): adopted; step copy and mock badge updated to the born-published model (type badge, no status badge). - Status badge menu (#146): superseded — visibility is the only state, toggled by the header eye; status_menu_controller removed. - Attachments dropzone (#147): superseded by our add-modal dropzone; spec selectors reconciled. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Mermaid diagrams render constrained to the content column, so anything beyond a trivial flowchart is too small to read.
What
<dialog>sized to the viewport, with the SVG scaled to fitdata-turbo-temporaryso Turbo never caches it.markdown-renderedRisk Assessment
Low — additive UI behavior scoped to rendered Mermaid diagrams; no server-side changes.
Screenshots
Inline diagram with the expand affordance on hover:
Clicking opens the lightbox, scaled to the viewport:
For comparison, the same diagram inline before expanding: