Add resolve/dismiss API endpoints for comment threads#16
Merged
Conversation
- PATCH /api/v1/plans/:plan_id/comments/:id/resolve - PATCH /api/v1/plans/:plan_id/comments/:id/dismiss - Policy authorization (plan author for dismiss, author or thread creator for resolve) - Turbo Stream broadcasts on status change - Request specs with auth coverage - Updated planning-department skill docs Amp-Thread-ID: https://ampcode.com/threads/T-019c90ba-6ddd-732d-9fe2-1ace4ba2a6fe Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new API endpoints for managing comment thread lifecycle:
PATCH /api/v1/plans/:plan_id/comments/:id/resolve— mark a thread as resolved (plan author or thread creator)PATCH /api/v1/plans/:plan_id/comments/:id/dismiss— dismiss a thread as not applicable (plan author only)Both endpoints enforce authorization via
CommentThreadPolicyand broadcast Turbo Stream updates so the web UI stays in sync.Changes
config/routes.rb— added resolve/dismiss member routesApi::V1::CommentsController— added resolve/dismiss actions with broadcastspec/requests/api/v1/comments_spec.rb— 5 new specs (happy path, 404, 403)SKILL.md— documented new endpoints and added 403 error codeAll 10 comment specs pass.