Ensure backwards and descending pagination work with id-only optimization. #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #205, I implemented an optimization, where we avoid a datastore query when the client is only requesting ids which we already have. As part of that, I implemented sorting and pagination support so that the expected page and ordering of ids are returned.
However, I only implemented the simplest case: foward ascending pagination. After merging that, I realized that my implementation wouldn't work for the three other pagination cases:
first: N, after: cursor, orderBy: [id_DESC]
)last: N, before: cursor, orderBy: [id_ASC]
)last: N, before: cursor, orderBy: [id_DESC]
)To fix those three cases, I had to change two things in the implementation:
sort
from thepagination
datastore body rather than directly fromquery
.query.sort
contains the sort order requested in the GraphQL query, but for some of the above cases we wind up reversing the sort direction we send in the datastore query.id > search_after
for all cases, but we need to useid < search_after
when we are sorting descending.