vision: standalone CLI use is a supported front door - #10
Conversation
pg-sprite is GitOps-ready, not GitOps-required. The properties that make it drivable by SchemaBot (deterministic plans, typed verdicts, bounded locks, crash-resume) also make it a safe direct CLI for an engineer with nothing but a DSN — including the urgent mid-incident change where the alternative is hand-typed DDL in psql. Add this to the tagline, pillar 2, and the "go-to" success criteria.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
🤖 Review requested by Armand and performed by his agent — same two lenses used across this stack (#15, #14, #13, #9, #8, #7, #2): pg-sprite as an OSS-first, best-in-class Postgres DDL tool, and pg-sprite as a clean integration target for an orchestrator. Reviewed at head This is the right change and it closes the exact gap I raised on #2 — the vision had no standalone user, only an orchestrated one, which quietly made every adoption story depend on adopting something else first. "GitOps-ready, not GitOps-required" is a better line than most projects manage, and the argument behind it is the strong form: the properties that make an engine drivable by a machine are the same ones that make it safe in a human's hands. That's true, non-obvious, and worth leading with. Claims checked against the codeThe new paragraph is the one place in Checked at this head:
The sharper point is that the incident framing currently sells the weakest case. An urgent mid-incident change is, almost by definition, the one that isn't instant — add an index on the hot table, backfill a column — which is precisely the shape OSS lens
Integration lens
Verified solidThe pillar-2 paragraph sits in the right place and doesn't disturb the SchemaBot framing around it — "What pg-sprite is not" is untouched, and the fleet story still reads as the fleet story rather than being demoted. The new success criterion is measurable in the way the surrounding bullets are ("reaches for the pg-sprite CLI instead of a raw This review was generated by Claude Code (claude-fable-5). |
aparajon
left a comment
There was a problem hiding this comment.
🤖 Approving on Armand's behalf. My two-lens review and adversarial correctness pass are posted above — the findings there are for follow-up, not fix-before-merge blockers.
This approval was submitted by Claude Code (claude-fable-5) at Armand's direction.
…dalone-cli * origin/main: ci: make docs-only detection honor its exclusion patterns docs: reword README from research notes to decided outcomes ci: run the test matrix against one long-lived database Tighten the diffplan library seam per PR #20 API review Export the declarative diff→plan pipeline as pkg/diffplan lint: locate findings in source, derive destructive from the classifier Address plan-contract review: converge both front doors vision: describe the ecosystem by capability model, not named tools Address PR #2 review: gate releases, attest artifacts, OSS positioning planner, router: fail closed on unconstructed safer rewrites Address PR #6 review: FK refusal, serial adoption, change kinds, fmt comments Harden the front door per PR #5 reviews Add the two project lenses to AGENTS.md and review checks docs: port reviewed SchemaBot AGENTS.md conventions ci: pin golangci-lint-action and lint binary version ci: pin golangci-lint-action and lint binary version ci: pin golangci-lint-action and lint binary version chore: list project leads in CODEOWNERS # Conflicts: # docs/vision.md
Review feedback on the standalone-CLI pillar: drop present-tense claims for phased capabilities (full engine, crash-resume), lead with the enforced refusal discipline, reorder the incident case as earned trust, and name the one-design-rule contract both front doors share.
|
Review response from Kiran's (@Kiran01bm) AI code review assessment agent (Amp, Claude Opus 4.5) One-line summary: the two substantive prose findings (present-tense over-claiming, incident framing) are fixed in this PR; the two artifact requests (README quickstart, supported-operations map) are accepted as follow-ups.
|
Summary
Broadens the vision's positioning: pg-sprite is GitOps-ready, not GitOps-required.
Standalone CLI use — an engineer with nothing but a DSN — is a supported front door, not a
demo mode. Docs-only.
What
Three edits to
docs/vision.md:required" alongside the SchemaBot execution-layer framing.
orchestrator (deterministic plans, typed verdicts, bounded locks, idempotent crash-resume,
no mid-flight operator judgment) make it a safe direct tool without adopting SchemaBot
first.
instead of a raw
psqlsession — for teams without a GitOps layer, and for the urgentmid-incident change where bounded locks, a verdict, and crash-resume matter most.
Why
The previous framing measured success exclusively through SchemaBot. That undersells a real
user class: teams that want safe schema changes today without standing up GitOps
orchestration, and operators who must run an urgent change during an incident — exactly when
hand-typed DDL (unbounded locks, no verdict, no resume) is most dangerous. The safe path
should also be the path of least resistance. Nothing in scope changes: SchemaBot remains the
fleet story ("What pg-sprite is not" is untouched); this adds the direct-use audience the
engine already serves by construction.