Bump Ministack to 1.4.15; adopt typed duplicate-instance fault match - #25
Merged
Conversation
The 1.4.14/1.4.15 releases carry fixes contributed upstream for this test tier: the duplicate-instance wire code now matches real AWS, so the deliberate divergence pin is replaced by the typed errors.As match production code uses, and the divergence note leaves docs/testing.md. 1.4.15 also validates EngineVersion against its creatable catalog at create time, so the per-major version map moves to catalog entries.
Kiran01bm
marked this pull request as ready for review
August 11, 2026 22:04
Kiran01bm
requested review from
JashLal,
aparajon,
eeSeeGee,
jayjanssen,
jemiahw and
morgo
as code owners
August 11, 2026 22:04
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
JashLal
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the pinned Ministack image for the AWS-boundary test tier from
1.4.13-fullto1.4.15-fulland adopts the fidelity fixes that release carries: the duplicate-instance divergence pin becomes the typederrors.Asmatch production code uses, and the engine-version map moves to versions the emulator's new create-time validation accepts.Why
Ministack v1.4.14/v1.4.15 include fixes contributed upstream specifically for this tier: the duplicate-instance wire code now matches real AWS (
DBInstanceAlreadyExists, noFaultsuffix),Stop/Startdo real compute lifecycle, andEngineVersionis validated against the creatable catalog at create time. The old divergence pin was written to fail the day the emulator was fixed, forcing this adoption — so the image bump and the typed-match flip land together.What
internal/testutil/ministack.go— pin1.4.15-full; moveauroraEngineVersionto catalog entries (14.23,15.18,16.14,17.10,18.4) since 1.4.15 rejects unknown versions with the AWS-exactInvalidParameterCombination; the unknown-major fallback becomes the bare major, which the validator accepts as a dot-boundary prefix.internal/testutil/ministack_integration_test.go— replace the pinned divergent wire-code assertion withrequire.ErrorAs(..., &types.DBInstanceAlreadyExistsFault{}), matching the cluster-level cases.docs/testing.md— the divergence note becomes a record that the gap was fixed upstream in v1.4.14.Verified:
make test-aws-boundarygreen against1.4.15-full(all three subtests),make lintclean, unit tier green.