refactor(config): remove deprecated operator_workers/scheduler_workers aliases#457
Draft
Kiran01bm wants to merge 1 commit into
Draft
refactor(config): remove deprecated operator_workers/scheduler_workers aliases#457Kiran01bm wants to merge 1 commit into
Kiran01bm wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the now-expired YAML compatibility layer for operator concurrency configuration by dropping the deprecated operator_workers / scheduler_workers aliases so drivers is the only accepted key. This simplifies config parsing under KnownFields(true) and removes the associated folding/validation logic and documentation references.
Changes:
- Removed
operator_workersandscheduler_workersfields fromServerConfigand deleted theresolveDeprecatedDriversfolding helper (and itsValidate()invocation). - Updated tests to stop asserting deprecated-key folding behavior.
- Updated docs to remove references to the deprecated aliases, documenting
driversas the sole operator concurrency key.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/api/operator_test.go | Removes tests that exercised deprecated alias folding into drivers. |
| pkg/api/config.go | Deletes deprecated config fields and the alias-resolution/fold logic from validation. |
| docs/configuration.md | Removes deprecation note for operator_workers / scheduler_workers in the Drivers section. |
| docs/architecture.md | Updates operator concurrency documentation to reference only drivers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aparajon
approved these changes
Jun 22, 2026
…s aliases drivers is now the only accepted key for operator concurrency; the compat aliases were retained only for one release after the rename soaked.
Kiran01bm
force-pushed
the
kiran01bm/schemabot-driver-alias-removal
branch
from
a83fd14 to
02763d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the deprecated
operator_workersandscheduler_workersconfig aliases (and theirKnownFields(true)compat fields), along with theresolveDeprecatedDriversfold logic and itsValidate()call.driversis now the only accepted key for operator concurrency. Docs and tests updated to match.Why
The aliases were kept for exactly one release after #438 renamed the key to
drivers, so existing configs would keep loading underKnownFields(true)with a deprecation warning. With the rename soaked, the compat layer is no longer needed.