status: expose structured checksum progress#986
Merged
Conversation
aparajon
force-pushed
the
aparajon/checksum-progress
branch
from
6a862a3 to
200bdce
Compare
morgo
reviewed
Jun 25, 2026
Progress carried checksum progress only inside the Summary string ("Checksum
Progress=X/Y Z%"), so programmatic consumers had to parse log output to recover
it. Add Checker.GetProgressRows (rows verified / total) and surface it as
status.Progress.Checksum during the checksum phase. A shared
formatChecksumProgress helper backs GetProgress and GetProgressRows so the
display string and structured data stay in sync.
aparajon
force-pushed
the
aparajon/checksum-progress
branch
from
200bdce to
e9bfcd3
Compare
Collapse Checker.GetProgress() and GetProgressRows() into a single GetProgress() that returns status.ChecksumProgress. Callers that want the display string call ChecksumProgress.String(), which now owns the "verified/total percent" formatting. This drops the parallel string/rows methods and the duplicated formatter, and keeps the structured data and its display form in one place as more checker implementations are added. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aparajon
force-pushed
the
aparajon/checksum-progress
branch
from
e9bfcd3 to
cb18957
Compare
morgo
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresscarried checksum progress only inside theSummarystring ("Checksum Progress=X/Y Z%"), so programmatic consumers (e.g. a control plane rendering per-table progress) had to parse log output to recover it.This adds:
Checker.GetProgressData() (rowsChecked, rowsTotal uint64)— the structured verified/total rows, on both the single and distributed checkers.status.Progress.Checksum(ChecksumProgress{RowsChecked, RowsTotal}) — populated while the migration is in the checksum phase, zero otherwise.A shared
formatChecksumProgresshelper backs bothGetProgress(the display string) andGetProgressData, so the two can't drift.