-
Notifications
You must be signed in to change notification settings - Fork 35
fix: all nodes process attestations #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -744,25 +744,16 @@ pub const BeamChain = struct { | |
| } | ||
| }; | ||
|
|
||
| if (self.is_aggregator_enabled) { | ||
| // Process validated attestation | ||
| self.onGossipAttestation(signed_attestation) catch |err| { | ||
| zeam_metrics.metrics.lean_attestations_invalid_total.incr(.{ .source = "gossip" }) catch {}; | ||
| self.logger.err("attestation processing error: {any}", .{err}); | ||
| return err; | ||
| }; | ||
| self.logger.info("processed gossip attestation for slot={d} validator={d}{f}", .{ | ||
| slot, | ||
| validator_id, | ||
| validator_node_name, | ||
| }); | ||
| } else { | ||
| self.logger.debug("skipping gossip attestation import (not aggregator): subnet={d} slot={d} validator={d}", .{ | ||
| signed_attestation.subnet_id, | ||
| slot, | ||
| validator_id, | ||
| }); | ||
| } | ||
| self.onGossipAttestation(signed_attestation) catch |err| { | ||
| zeam_metrics.metrics.lean_attestations_invalid_total.incr(.{ .source = "gossip" }) catch {}; | ||
| self.logger.err("attestation processing error: {any}", .{err}); | ||
| return err; | ||
| }; | ||
| self.logger.info("processed gossip attestation for slot={d} validator={d}{f}", .{ | ||
| slot, | ||
| validator_id, | ||
| validator_node_name, | ||
| }); | ||
| zeam_metrics.metrics.lean_attestations_valid_total.incr(.{ .source = "gossip" }) catch {}; | ||
| return .{}; | ||
|
Comment on lines
+747
to
758
|
||
| }, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
processed gossip attestation...is logged at info level for every successfully imported attestation. Now that all nodes will process gossip attestations (not just aggregators), this can dramatically increase log volume and I/O overhead in normal operation. Consider downgrading this to debug (or adding sampling / rate limiting) to keep info logs actionable.