Refactor/centralize foward fill logic #1541
Merged
+568
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
LeonardoVieira1630
requested review from
PedroBinotto,
alextnetto,
brunod-e,
edulennert and
pikonha
as code owners
pikonha
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
time-series.tsmodule inapps/indexer/src/lib/containing reusable time-series utilitiesChanges
New Centralized Module (
apps/indexer/src/lib/time-series.ts)truncateTimestampToMidnight- Truncate timestamp to midnight UTCforwardFill- Forward-fill sparse data across a timeline (generic, works with any key/value types)createDailyTimeline- Generate daily timestamps between two datesfilterWithFallback- Filter data by cutoff with fallback to last valuegetLastValueBefore- Get last data point before a given datecalculateCutoffTimestamp- Calculate cutoff timestamp for N days agonormalizeMapTimestamps- Normalize all map timestamps to midnightRefactored Services
delegation-percentage- Now uses centralizedforwardFillandcreateDailyTimelinetreasury.service- Migrated to usetime-seriesutilitiesnft-price- Migrated to usetime-seriesutilitiescoingecko- Migrated to usetime-seriesutilitiesdefillama-provider- Now usesfilterWithFallbackdune-provider- Now usesfilterWithFallbackRemoved
apps/indexer/src/api/services/treasury/forward-fill.ts- Replaced by centralized moduleeventHandlers/shared.ts- Moved totime-series.ts