chore: bump elixir to 1.16.3 and Erlang OTP to 26.2.5.1 by k1rill-fedoseev · Pull Request #9256 · blockscout/blockscout

k1rill-fedoseev · 2024-01-25T13:56:15Z

Changelog

Migrate to the latest elixir stack versions:
- Elixir 1.16.3
- Erlang OTP 26.2.5
Fix various compilation/linter/credo/dialyzer warnings
Fix compilation issues coming from prometheus_process_collector dependency
- Compilation on Apple Silicon chips (macOS: drop explicit -arch flags prometheus-erl/prometheus_process_collector#24)
- Compilation on OTP 26 (Fix: compile on OTP26 prometheus-erl/prometheus_process_collector#30)
Resolve some cyclic dependencies (probably related to https://hexdocs.pm/elixir/1.15.7/changelog.html#potential-incompatibilities)

Checklist for your Pull Request (PR)

I added an entry to CHANGELOG.md with this PR
If I added new functionality, I added tests covering it.
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
I checked whether I should update the docs and did so by submitting a PR to https://github.com/blockscout/docs
If I added/changed/removed ENV var, I submitted a PR to https://github.com/blockscout/docs to update the list of env vars at https://github.com/blockscout/docs/blob/master/for-developers/information-and-settings/env-variables.md and I updated the version to master in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.
If I add new indices into DB, I checked, that they are not redundant with PGHero or other tools

k1rill-fedoseev · 2024-01-25T18:59:11Z

apps/indexer/test/indexer/fetcher/token_instance/metadata_retriever_test.exs

@@ -1,4 +1,4 @@
-defmodule Explorer.Token.InstanceMetadataRetrieverTest do
+defmodule Indexer.Fetcher.TokenInstance.MetadataRetrieverTest do


Moved the test to get rid of Explorer -> Indexer dependency

k1rill-fedoseev · 2024-01-25T19:02:04Z

apps/indexer/test/indexer/buffered_task_test.exs

                 max_batch_size: 1,
-                 max_concurrency: 1
+                 max_concurrency: 1,
+                 poll: false


Seems like the test didn't properly work in elixir 1.14, didn't manage to debug the reason why.
Without poll: false, BufferedTask will attempt to call init/2 when given an empty queue.

k1rill-fedoseev · 2024-01-25T19:03:08Z

apps/explorer/test/explorer/exchange_rates/source/coin_gecko_test.exs


      on_exit(fn ->
-        Application.put_env(:explorer, :coin, "POA")
+        Application.put_env(:explorer, :coin, "ETH")


Setting env to a non-default value breaks test sometimes in a different file.

k1rill-fedoseev · 2024-01-25T19:05:11Z

apps/explorer/lib/explorer/account/notifier/email.ex


  defp address_url(address_hash) do
-    Helpers.address_url(uri(), :show, address_hash)
+    uri() |> URI.append_path("/address/#{address_hash}") |> to_string()


Elixir doesn't like cyclic dependencies now, so this is probably the easiest way to remove Explorer -> BlockScoutWeb dependency

k1rill-fedoseev · 2024-01-25T19:07:32Z

apps/block_scout_web/mix.exs

-      # OS process metrics for Prometheus
-      {:prometheus_process_collector, "~> 1.3"},
+      # OS process metrics for Prometheus, custom ref to include https://github.com/deadtrickster/prometheus_process_collector/pull/30
+      {:prometheus_process_collector,


There is a new upstream release for prometheus_ex, btw - https://github.com/deadtrickster/prometheus.ex/releases/tag/v3.1.0
We might wanna update in a separate PR.

k1rill-fedoseev · 2024-01-29T08:57:24Z

apps/explorer/test/explorer/market/market_test.exs

  end

  test "fetch_recent_history/1" do
+    ConCache.delete(:market_history, :last_update)


Another test cached an empty value causing this test to fail.

vbaranov

@k1rill-fedoseev could you please rebase to master branch? There are merging conflicts currently: I recently moved OTP_VERSION and ELIXIR_VERSION to github envs and re-used them in Github actions workflows.

k1rill-fedoseev requested a review from vbaranov January 25, 2024 13:56

k1rill-fedoseev self-assigned this Jan 25, 2024

k1rill-fedoseev commented Jan 25, 2024

View reviewed changes

k1rill-fedoseev requested review from Qwerty5Uiop, nikitosing and sl1depengwyn January 26, 2024 10:12

k1rill-fedoseev commented Jan 29, 2024

View reviewed changes

vbaranov reviewed Feb 7, 2024

View reviewed changes

k1rill-fedoseev force-pushed the kf-bump-elixir-1.16.0 branch from e44d381 to 2cfba96 Compare February 7, 2024 18:30

k1rill-fedoseev requested a review from vbaranov February 7, 2024 18:31

k1rill-fedoseev changed the title ~~Bump elixir to 1.16.0 and Erlang OTP to 26.2.1~~ Bump elixir to 1.16.1 and Erlang OTP to 26.2.1 Feb 7, 2024

k1rill-fedoseev force-pushed the kf-bump-elixir-1.16.0 branch from 263e0d0 to e22f9e7 Compare February 22, 2024 10:39

k1rill-fedoseev force-pushed the kf-bump-elixir-1.16.0 branch from e22f9e7 to 4086eb5 Compare May 29, 2024 18:51

k1rill-fedoseev changed the title ~~Bump elixir to 1.16.1 and Erlang OTP to 26.2.1~~ Bump elixir to 1.16.3 and Erlang OTP to 26.2.5 May 29, 2024

k1rill-fedoseev changed the title ~~Bump elixir to 1.16.3 and Erlang OTP to 26.2.5~~ chore: bump elixir to 1.16.3 and Erlang OTP to 26.2.5 May 29, 2024

k1rill-fedoseev force-pushed the kf-bump-elixir-1.16.0 branch from 833eab6 to 36d7010 Compare June 10, 2024 08:33

sl1depengwyn approved these changes Jun 13, 2024

View reviewed changes

vbaranov changed the title ~~chore: bump elixir to 1.16.3 and Erlang OTP to 26.2.5~~ chore: bump elixir to 1.16.3 and Erlang OTP to 26.2.5.1 Jul 1, 2024

vbaranov force-pushed the kf-bump-elixir-1.16.0 branch from e89e285 to a2dc43e Compare July 1, 2024 12:27

vbaranov approved these changes Jul 1, 2024

View reviewed changes

vbaranov mentioned this pull request Jul 1, 2024

There is a new upstream release for prometheus_ex, btw - https://github.com/deadtrickster/prometheus.ex/releases/tag/v3.1.0 #10345

Closed

vbaranov force-pushed the kf-bump-elixir-1.16.0 branch from a2dc43e to 31b6a37 Compare July 1, 2024 12:53

k1rill-fedoseev added 8 commits July 1, 2024 18:35

feat: bump elixir to 1.16.0

a7b8865

fix: failing tests

052f1f2

fix: one more test

b4c1265

fix: qemu arm build

f334f87

fix: failing market test

3a3796a

fix: override version in ci

0111cee

chore: bump to 1.16.1

5f78abc

fix: ci config override

27a5074

k1rill-fedoseev and others added 8 commits July 1, 2024 18:35

chore: bump to 1.16.3

3f1a1a2

chore: mix format

d502792

fix: faulty explorer tests

515a74a

fix: faulty block_scout_web tests

33d6614

chore: lint

a54c5e3

ci: remove arm build workaround

f7aed9d

chore: fix negative slice warnings

130fb8b

Erlang 26.2.5.1

0eb3585

vbaranov force-pushed the kf-bump-elixir-1.16.0 branch from 31b6a37 to 0eb3585 Compare July 1, 2024 15:35

vbaranov merged commit 7fe5bb9 into master Jul 1, 2024

vbaranov deleted the kf-bump-elixir-1.16.0 branch July 1, 2024 18:04

vbaranov mentioned this pull request Jul 2, 2024

fix: Apply Ecto set explicit ssl_opts: [verify: :verify_none] to all prod repos #10369

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump elixir to 1.16.3 and Erlang OTP to 26.2.5.1#9256

chore: bump elixir to 1.16.3 and Erlang OTP to 26.2.5.1#9256
vbaranov merged 16 commits intomasterfrom
kf-bump-elixir-1.16.0

k1rill-fedoseev commented Jan 25, 2024 •

edited

Loading

Uh oh!

k1rill-fedoseev Jan 25, 2024

Uh oh!

k1rill-fedoseev Jan 25, 2024

Uh oh!

k1rill-fedoseev Jan 25, 2024

Uh oh!

k1rill-fedoseev Jan 25, 2024

Uh oh!

k1rill-fedoseev Jan 25, 2024

Uh oh!

k1rill-fedoseev Jan 29, 2024

Uh oh!

vbaranov left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1,4 +1,4 @@
		defmodule Explorer.Token.InstanceMetadataRetrieverTest do
		defmodule Indexer.Fetcher.TokenInstance.MetadataRetrieverTest do

Conversation

k1rill-fedoseev commented Jan 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Checklist for your Pull Request (PR)

Uh oh!

k1rill-fedoseev Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

k1rill-fedoseev Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

k1rill-fedoseev Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

k1rill-fedoseev Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

k1rill-fedoseev Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

k1rill-fedoseev Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

vbaranov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

k1rill-fedoseev commented Jan 25, 2024 •

edited

Loading