fdb: remove class_override; resolve fdb class from gbl tunables#6032
Open
dorinhogea wants to merge 1 commit into
Open
fdb: remove class_override; resolve fdb class from gbl tunables#6032dorinhogea wants to merge 1 commit into
dorinhogea wants to merge 1 commit into
Conversation
Class/local are set at fdb creation from foreign_db_resolve_local and foreign_db_resolve_tier tunables. Per-statement _ prefix overrides are deprecated and ignored with a rate-limited warning. Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
roborivers
suggested changes
Jun 17, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
fdb_compare_rte_connect_generated
fdb_compare
sql_logfill_autodisable
consumer_non_atomic_default_consumer_generated **quarantined**
remsql_rte_connect_generated
remtran_origin
remsql_locks_rte_connect_generated
remsql_locks
remsql_fdbpushredirect_generated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class/local are set at fdb creation from foreign_db_resolve_local and foreign_db_resolve_tier tunables. Per-statement _ prefix overrides are deprecated and ignored with a rate-limited warning.
This simplifies greatly the fdb sqlite interactions; this is a pre-requirement for tracking remote stats version in fdb core.