Skip to content

Changed the one step checkout so that it uses more original odoo co…#1

Open
nafex wants to merge 1 commit intoblooparksystems:masterfrom
nafex:master
Open

Changed the one step checkout so that it uses more original odoo co…#1
nafex wants to merge 1 commit intoblooparksystems:masterfrom
nafex:master

Conversation

@nafex
Copy link

@nafex nafex commented May 26, 2015

…de. To be more update safe.

@jholze
Copy link
Member

jholze commented May 27, 2015

@nafex @rruebner @christophlsa Suggestion from my side: lets split the checkout in a generic checkout addon which is useable for all countries and more odoo default based and lets create some small addons for country based enhancements like profiles in the OCA bank statement import addons eg. osc_custom_german ...

Just an idea.

@christophlsa
Copy link
Contributor

Some general notes to the changes:

  • Several parts in the controllers and javascript files were removed/changed. Here we have to look what you changed.
  • The addon was changed to remove the ability to (de)activate the whole one step checkout without uninstalling the addon. We should discuss if this is a good idea. @jholze
    • Pro: We are saving no values in the models (except the config options). So no data will be removed on uninstallation. Also we need no further steps to really use the onestepcheckout. Further we can remove some conditions and use more odoo core parts.
    • Contra: To temporary deactivate the onestep checkout you have to uninstall the addon. If you create addons which have a dependency on this addon then they will also uninstalled (with potential data loss).
  • The functionality of the manual selection of the allowed countries was removed. Here we should also discuss if this functionality is desired in the "base addon". @jholze
  • Depending on the outcome of the both last points the options should be removed if the functionality is removed.

Further comments will be done directly at the changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not working correctly. The template is not translated correctly. (edit: see lines below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants