Add RFC 7986 NAME property for calendar title compatibility#34
Open
vyakart wants to merge 2 commits intoblr-today:mainfrom
Open
Add RFC 7986 NAME property for calendar title compatibility#34vyakart wants to merge 2 commits intoblr-today:mainfrom
vyakart wants to merge 2 commits intoblr-today:mainfrom
Conversation
The mobile navigation was using :hover CSS pseudo-class which does not work well on touch devices. On mobile, :hover is triggered on tap but immediately deactivated, causing the menu to collapse instantly. This fix adds JavaScript-based toggle functionality that: - Keeps the menu open after tapping the first menu item - Closes the menu when clicking outside the navigation - Closes the menu when clicking any navigation link - Only activates on mobile screens (max-width: 40rem) The solution adds a mobile-menu-open class that works with the existing CSS mobile navigation pattern from classless.css. Fixes blr-today#15
Fixes blr-today#16 by adding the standard NAME property alongside the legacy X-WR-CALNAME property. This ensures calendar titles are properly displayed in iOS Calendar and Thunderbird, which don't recognize the non-standard X-WR-CALNAME property. The NAME property is part of RFC 7986 and is the official standard for specifying calendar names. Keeping X-WR-CALNAME maintains backward compatibility with older calendar clients.
✅ Deploy Preview for blr-today ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NAMEproperty to iCalendar filesX-WR-CALNAMEfor older clientsProblem
iOS Calendar and Thunderbird were ignoring calendar titles because the layout only used the non-standard
X-WR-CALNAMEproperty.Solution
Added the RFC 7986 standard
NAMEproperty alongsideX-WR-CALNAME:NAME: RFC 7986 official standard - recognized by iOS and modern clientsX-WR-CALNAME: Legacy property - maintained for backward compatibilityTesting
References