Repository navigation
Group metadata generated by queueserver under 'queue_server' key - #385
Merged
Merged
Conversation
Assisted-by: oh-my-pi:claude-sonnet-5
dmgav
reviewed
Oct 5, 2026
| plan_args_parsed = plan_parsed["args"] | ||
| plan_kwargs_parsed = plan_parsed["kwargs"] | ||
| plan_meta_parsed = {**plan_parsed["meta"], "queue_item_uid": plan_info["item_uid"]} | ||
| plan_meta_parsed = {**plan_parsed["meta"], "queue_server": {"queue_item_uid": plan_info["item_uid"]}} |
Contributor
There was a problem hiding this comment.
I don't think it's a good idea to replace everything under the 'queue_server'. We need to add the queue_server key if it doesn't exist or replace queue_item_uid if the queue_server key exists.
Contributor
There was a problem hiding this comment.
The use case: assume that HTTP server will add some additional data to queue_server, which needs to be passed through.
Contributor
Author
There was a problem hiding this comment.
Done, every key is preserved except queue_item_uid. Also, if queue_server isn't a dict, it must be replaced.
dmgav
reviewed
Oct 5, 2026
…em_uid Assisted-by: oh-my-pi:claude-sonnet-5
thopkins32
commented
Oct 5, 2026
Comment on lines
+968
to
+977
| ({"queue_server": {"queue_item_uid": 123}, "test_key": "test_value"}, {"test_key": "test_value"}), | ||
| # Queue Server-assigned metadata is merged into a submitted 'queue_server' dict: the conflicting | ||
| # 'queue_item_uid' is overridden, but other keys in the dict are preserved. | ||
| ( | ||
| { | ||
| "queue_server": {"queue_item_uid": "submitted_item_uid", "custom_key": "custom_value"}, | ||
| "test_key": "test_value", | ||
| }, | ||
| {"test_key": "test_value"}, | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
@dmgav don't these test the same thing now?
dmgav
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: oh-my-pi:claude-sonnet-5
Description
Closes #384