-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PVI information to fill in PVs on FastCS Eiger #806
base: main
Are you sure you want to change the base?
Conversation
f8a65da
to
4776910
Compare
def __init__(self, uri: str, name: str = ""): | ||
super().__init__(name=name, connector=fastcs_connector(self, uri)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss this in the standup later, I'm not sure what is a top level controller in FastCS here...
This API doesn't seem very clear now that I am seeing it on the ophyd side... Maybe we can improve the names in fastcs-odin. |
Above is a table of current Odin signal names (i.e., ADOdin), and API signal names (i.e., Fast-CS Odin) that are not in agreement. Recommended names are provided (yet to be filled). |
Can I suggest spinning the name changes off into a separate issue? Doing just a find and replace later won't be too much effort and it decouples getting the issue complete from fastcs changes |
The name changes in ophyd-async? Unfortunately we can't do this, the name in PVI is the name of the attribute in the ophyd-async Device. This ticket is to use PVI to make the Eiger and Odin Devices, so I think we need to decide on names as part of this ticket... It's possible to make a different ticket that keeps the old attribute names, but fills in the PVs from the new FastCS Eiger, but I'm not sure it is worth the effort to do that intermediate step unless you need to keep switching between the two IOCs, optimizing both... Can we discuss in standup today? |
Fixes #551
This PR should create FastCS modules for Eiger and Odin, and write the Eiger in a declarative style with typed annotations. Currently annotations are limited to signals internatlly used by the device, and those accessed in the MX DAQ Eiger arming chain. These signals should now follow the expected format of PVI attributes.
Notes for reviewer:
These changes were made for FastCS Odin as well;
capture
signal, which readsWriting
and writes toConfigHDFWrite
was split into two signals, which seems messy. Moreover, attribute names seem quite ambiguous.