fix: Moves AgentVibes TTS prompt after tool selection with smart defaults (Y if Claude Code selected)

[paulpreibisch]

Summary

• Fixes npm prefix environment variable inheritance issue when BMAD is invoked with --prefix flag
• Clears ALL npm_config_* and npm_package_* environment variables before spawning AgentVibes installer subprocess
• Swaps bmad-master and pm (John) voice assignments for better persona fit
• Moves AgentVibes TTS prompt after tool selection with smart defaults (Y if Claude Code selected)
• Generates voice map CSV with intro messages for party mode agent introductions
• Updates party mode to have agents introduce themselves automatically on activation

Problem

When BMAD is invoked with npm --prefix /some/path install, npm sets many environment variables that get inherited by child processes. This caused the AgentVibes installer to fail with:

ENOENT: no such file or directory, lstat '/home/fire/claude/BMAD-METHOD/lib'

Solution

1. Clean npm environment

Filter out all npm configuration environment variables before calling npx agentvibes@latest install:

const cleanEnv = Object.fromEntries(
  Object.entries(process.env).filter(
    ([key]) => !key.startsWith('npm_config_') && !key.startsWith('npm_package_')
  ),
);

2. Voice assignment swap

• bmad-master: en_US-ryan-high -> en_US-lessac-medium
• pm (John): en_US-lessac-medium -> en_US-ryan-high

3. Smart AgentVibes prompt

• Move TTS prompt to after IDE/tool selection
• Default to Y if Claude Code is selected (AgentVibes only works with Claude Code)
• Default to N if Claude Code is not selected

4. Voice map with intros

• Generate _cfg/agent-voice-map.csv during BMAD install
• Include intro column with personality-specific introduction messages
• Party mode now automatically has 3-4 agents introduce themselves on activation

Test plan

• Install BMAD using npm --prefix /some/test/dir install bmad-method
• Verify AgentVibes installer launches successfully without path errors
• Verify installation completes in the correct target directory
• Verify voice map CSV is generated with correct voice assignments
• Verify party mode agents introduce themselves automatically

🤖 Generated with Claude Code

[bmadcode]

nit: remove (optional) - if not, especially codex, will choose to just skip the whole section without even looking at the if condition within the section.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[paulpreibisch]

✅ Test Results

All BMAD tests passing successfully:

Schema Validation Tests

• ✅ 49/49 tests passed
• All agent schema validations working correctly
• Invalid schema tests catching errors as expected
• Valid schema tests passing

Installation Component Tests

• ✅ 13/13 tests passed
• Agent compilation working correctly
• Customization merging functioning properly
• Path variable resolution validated
• TEA agent compilation verified

Schema Validation

• ✅ 21/21 agent files validated
• All core and module agents passing validation

Linting

• ✅ ESLint passed with 0 warnings

Note: The only minor issue is a permission error on markdownlint-cli2, which doesn't affect the core functionality.

All critical tests are passing for PR #987! ✨