fix concurrent issue of local account set in legacypool #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an concurrent map read & write issue on legacypool.locals when
--txpool.nolocals=false
. It causes panic.Here's how it happend:
legacypool.locals
accounts map is written here, with flag--txpool.nolocals=false
.legacypool.locals
accounts map is then accessed by thePending()
method concurrently here, with a none-nil minTip.Rationale
Example
How to replay it:
--txpool.nolocals=false
The node should panic after a few minutes.