Skip to content

Update test262.yml #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thedgarg31
Copy link

This Pull Request fixes/closes - Update workflows permission to allow forked PRs to have commented results #4105

It changes the following:

Added missing permissions in workflows to allow benchmarks and test262 results to be commented back on forked PRs.
Updated test262.yml to ensure test results are posted correctly using create-or-update-comment.
Ensured compatibility with the latest GitHub Actions permissions to allow the workflow to interact with PR comments.

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.65%. Comparing base (6ddc2b4) to head (54c3326).
Report is 392 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4206      +/-   ##
==========================================
+ Coverage   47.24%   52.65%   +5.41%     
==========================================
  Files         476      487      +11     
  Lines       46892    51981    +5089     
==========================================
+ Hits        22154    27371    +5217     
+ Misses      24738    24610     -128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jedel1043
Copy link
Member

jedel1043 commented Mar 13, 2025

Of course it wouldn't be that easy...

I think the action itself assumes it's not running on a fork, and based on peter-evans/create-or-update-comment#39, we'll have to create a bot app instead.

Thank you for testing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants