Add POSIX time zone string support to zoneinfo#265
Merged
Conversation
It's time to finally tackle the zoneinfo and tzif sourcing issue. The work here lays the baseline for to handle sourcing. There's still a lot more to add, and maybe some bugs to uncover. But this is also major progress.
nekevss
force-pushed
the
add-posix-tz-string
branch
from
06b1e92 to
0954207
Compare
This was referenced Apr 20, 2025
nekevss
force-pushed
the
add-posix-tz-string
branch
from
0754cd9 to
4fd4c85
Compare
nekevss
force-pushed
the
add-posix-tz-string
branch
from
ed7ed3a to
7e434a2
Compare
Member
Author
|
This is finally updated and more or less ready for review. I ended up going with a struct for the |
HalidOdat
approved these changes
Jul 16, 2025
HalidOdat
left a comment
HalidOdat
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
Just had a minor nitpick and some questions 😄
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
github-project-automation
Bot
moved this from In review
to Done
in Temporal Implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for POSIX time zone strings based off the GNU tz variable documentation.