Switch FFI calendar APIs over to using AnyCalendarKind for input#324
Merged
Conversation
Manishearth
force-pushed
the
calendar-kind
branch
3 times, most recently
from
c14574b to
447dca3
Compare
Manishearth
force-pushed
the
calendar-kind
branch
from
447dca3 to
b84630c
Compare
nekevss
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We clone these calendars anyway; the current API forces clients to retain some allocated Calendar objects for no real reason. Let's standardize around using kinds.
This breaks the CAPI, but I'm not using this stuff yet. If I decide to start using this before a release, I'll add some compat layer for the APIs I care about.