Use a lock internally to FsTzdbProvider instead of externally#327
Merged
Conversation
Merged
nekevss
approved these changes
Jun 3, 2025
Contributor
Author
|
(Needs a merge) |
github-project-automation
Bot
moved this from In review
to Done
in Temporal Implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It already uses interior mutability, we don't gain much by having the lock be external in
TZ_PROVIDER.By having it be internal, the critical section of tzdb stuff is limited to the caching logic, rather than anything larger.