Cross boundary rounding fix #286#343
Merged
Merged
Conversation
Add cross boundary rounding tests
nekevss
approved these changes
Jun 9, 2025
nekevss
left a comment
nekevss
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this! This is definitely a needed addition.
My guess is that these were probably fixed in #322. We didn't have tests in place to technically close #286, just the boa test results. The tests results weren't enough to close the issue, in my opinion, unless we had tests like this PR or the next release in place downstream with Boa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unable to reproduce the reported bug, but new tests now cover the described scenarios.