Add from_partial for YearMonth/MonthDay FFI#351
Conversation
|
Just to confirm, have you seen #342? That's going to be a breaking change here to YearMonth::from_partial |
|
I have not, that is also an acceptable API. Still need it for MonthDay though. Happy to wait, I have an acceptable workaround for now. |
|
I think I'd prefer to wait on this for now. Because there's also #349 to consider too. |
|
I'm actually finding myself needing this: the current API is insufficient to implement ToTemporalYearMonth, which needs a way to pass down monthCode. The current hacky implementation I have fails tests. |
|
Sounds good. I think this really just needs to be updated to the more recent changes. |
|
Oh, wait, I didn't realize #342 landed. I should just use that lol. |
|
Ah, I still need it over FFI. |
|
I'll keep this PR open until I can fix that. |
edab86d to
5de14a1
Compare
|
@nekevss I updated this to use the new PartialYearMonth. Over FFI I still use PartialDate for both of these. I could add a PartialYearMonth over FFI but I don't actually have the need to have nitty gritty Partial types here.
|
No description provided.