Skip to content

Add baseline ZoneInfo64 data provider #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nekevss wants to merge 3 commits into from
Closed

Add baseline ZoneInfo64 data provider #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
841d123
Add baseline ZoneInfo64 provider
nekevss Jun 4, 2025
3c3fcd6
Remove zoneinfo64 from default list
nekevss Jun 18, 2025
1d97066
Make deps optional
nekevss Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ tzif = "0.3.0"
jiff-tzdb = "0.1.4"
combine = "4.6.7"
web-time = "1.1.0"
writeable = "0.6.1"

[package]
name = "temporal_rs"
Expand All @@ -60,7 +61,7 @@ icu_locale.workspace = true
ixdtf = { workspace = true, features = ["duration"]}
num-traits.workspace = true
tinystr.workspace = true
writeable = "0.6.1"
writeable.workspace = true

# log feature
log = { workspace = true, optional = true }
Expand Down
12 changes: 11 additions & 1 deletion provider/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,20 @@ include = [
]

[features]
datagen = ["dep:parse-zoneinfo", "dep:serde", "dep:databake",
default = []
datagen = ["std", "dep:parse-zoneinfo", "dep:serde", "dep:databake",
"dep:yoke", "dep:serde_json",
"zerotrie/serde", "zerotrie/databake", "zerovec/serde", "zerovec/databake"]
zoneinfo64-provider = ["dep:serde", "zerovec/serde", "zerovec/derive", "zerovec/databake", "writeable", "resb", "rustc-hash"]
std = []


[dependencies]

# Provider dependency
zerotrie = "0.2.2"
zerovec = "0.11.2"
zerofrom = "0.1.6"

# IANA dependency
parse-zoneinfo = {version = "0.3.1", optional = true }
Expand All @@ -34,3 +40,7 @@ databake = { version = "0.2.0", features = ["derive"], optional = true }
yoke = { version = "0.8.0", features = ["derive"], optional = true }
serde_json = { version = "1.0.140", optional = true }

# ZoneInfo64 dependencies
resb = { git = "https://github.com/unicode-org/icu4x.git", optional = true }

@Manishearth Manishearth Jun 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cut a release; make a PR to ICU4X that finalizes the resb Cargo.toml (make it publish = false), write a changelog entry, and ping me for a release.

rustc-hash = { workspace = true, optional = true }
writeable = { workspace = true, optional = true }

@HalidOdat HalidOdat Jun 21, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace 👮‍♂️

Suggested change
writeable = { workspace = true, optional = true }
writeable = { workspace = true, optional = true }

Loading
Loading