Add documentation and doctests for builtins#360
Merged
Conversation
nekevss
requested changes
Jun 22, 2025
nekevss
left a comment
nekevss
left a comment
Member
There was a problem hiding this comment.
Overall, this looks fantastic! Thanks for working on this!
I have a few nitpicks / suggestions that I've filled out below. The big points that I would highlight is: try to use core over std wherever possible in examples, and try to prefer RFC9557(IXDTF) / ISO8601 grammar wherever possible when mentioning date time in a string.
blarfoon
changed the title
blarfoon
changed the title
Member
|
I think this may need a rebase to handle the conflict. After an initial glance, this is looking good. |
nekevss
approved these changes
Jun 25, 2025
nekevss
left a comment
nekevss
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for working on this 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation and doctests for builtin types, including MDN references and examples on how to use them with popular use cases.
#107