Use bulk mode in class name completion (fixes #40)#42
Closed
derSascha wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@bobbylight what do you think about the PR? Its a very small but very power full fix. |
This was referenced Jun 19, 2025
Owner
|
Closing in favor of #83. Thanks @derSascha ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Java class name completion on large jar files (e.g. Spark, 35MB, 22K Classes) takes long (e.g. Class names with an A takes ~180 Seconds).
Open the jar and seeking to the class on each class takes very long:
RSTALanguageSupport/src/main/java/org/fife/rsta/ac/java/buildpath/JarLibraryInfo.java
Lines 96 to 104 in c4ff0a2
Instead of open the jar on every class, use the bulk API on class name completion. This reduce the time in the example above to ~3s.