Increase strictness of checkstyle on JS support#85
Merged
Conversation
bobbylight
force-pushed
the
improve-checkstyle-on-js-support
branch
from
05b9469 to
be91dc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is huge, but it's the start of making checkstyle more strict on the JS language support.
Previously, it was completely disabled for the JS support via the
lsSuppressions.xmlfile. Now it is only suppressed for certain rules (admittedly a lot of them). I fixed several issues to get to this point, but not all of them - there are so many checkstyle violations I think that moving forward, it would be clearer from a PR perspective to fix them one per-PR rather than doing them all at once (this PR is already too large and addresses too many issues).