Skip to content

Enable checkstyle ExplicitInitialization rule for JS support #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbylight merged 1 commit into from
Jun 22, 2025
Merged

Enable checkstyle ExplicitInitialization rule for JS support #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/JavaScriptHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ public static boolean isInfixOnly(AstNode typeNode) {
*/
private static final class InfixVisitor implements NodeVisitor {

private String type = null;
private String type;
private SourceCompletionProvider provider;

private InfixVisitor(SourceCompletionProvider provider) {
Expand Down
4 changes: 2 additions & 2 deletions RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/SourceCompletionProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ public void setShorthandCache(ShorthandCompletionCache shorthandCache) {
}


private String lastCompletionsAtText = null;
private List<Completion> lastParameterizedCompletionsAt = null;
private String lastCompletionsAtText;
private List<Completion> lastParameterizedCompletionsAt;

@Override
public List<Completion> getCompletionsAt(JTextComponent tc, Point p) {
Expand Down
12 changes: 6 additions & 6 deletions RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/JavaScriptFunctionType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ public final class JavaScriptFunctionType {
public static Class<?> ShortClass = Kit.classOrNull("java.lang.Short");
public static Class<?> StringClass = Kit.classOrNull("java.lang.String");
public static Class<?> DateClass = Kit.classOrNull("java.util.Date");
public static Class<?> JSBooleanClass = null;
public static Class<?> JSStringClass = null;
public static Class<?> JSNumberClass = null;
public static Class<?> JSObjectClass = null;
public static Class<?> JSDateClass = null;
public static Class<?> JSArray = null;
public static Class<?> JSBooleanClass;
public static Class<?> JSStringClass;
public static Class<?> JSNumberClass;
public static Class<?> JSObjectClass;
public static Class<?> JSDateClass;
public static Class<?> JSArray;

private String name;
private List<TypeDeclaration> arguments;
Expand Down
2 changes: 1 addition & 1 deletion ...guageSupport/src/main/java/org/fife/rsta/ac/js/resolver/JavaScriptCompletionResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class JavaScriptCompletionResolver extends JavaScriptResolver {


protected JavaScriptType lastJavaScriptType;
protected String lastLookupName = null;
protected String lastLookupName;


/**
Expand Down
2 changes: 1 addition & 1 deletion ...anguageSupport/src/main/java/org/fife/rsta/ac/js/tree/JavaScriptOutlineTreeGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class JavaScriptOutlineTreeGenerator implements NodeVisitor {

private JavaScriptTreeNode curScopeTreeNode;

private Map<String, List<JavaScriptTreeNode>> prototypeAdditions = null;
private Map<String, List<JavaScriptTreeNode>> prototypeAdditions;


JavaScriptOutlineTreeGenerator(RSyntaxTextArea textArea,
Expand Down
2 changes: 1 addition & 1 deletion config/checkstyle/lsSuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
For now we're ignoring several issues that will take some time to address.
TODO: Remove these issues one by one.
-->
<suppress files=".*src[\\/]main[\\/]java[\\/]org[\\/]fife[\\/]rsta[\\/]ac[\\/]js[\\/].*" checks="AvoidNestedBlocks|ExplicitInitialization|JavadocTagContinuationIndentation|JavadocMethod|JavadocPackage|JavadocStyle|LineLength|MissingJavadocMethod|MissingJavadocType|NeedBraces|NonEmptyAtclauseDescription|OperatorWrap|StaticVariableName|VisibilityModifier"/>
<suppress files=".*src[\\/]main[\\/]java[\\/]org[\\/]fife[\\/]rsta[\\/]ac[\\/]js[\\/].*" checks="AvoidNestedBlocks|JavadocTagContinuationIndentation|JavadocMethod|JavadocPackage|JavadocStyle|LineLength|MissingJavadocMethod|MissingJavadocType|NeedBraces|NonEmptyAtclauseDescription|OperatorWrap|StaticVariableName|VisibilityModifier"/>

<!-- Lots of blocks are empty with "TODO" comments describing future implementations -->
<suppress files=".*src[\\/]main[\\/]java[\\/]org[\\/]fife[\\/]rsta[\\/]ac[\\/].*" checks="EmptyBlock"/>
Expand Down