This repository was archived by the owner on Apr 5, 2018. It is now read-only.
Adding ability to merge tags#3
Open
pichot wants to merge 1 commit into
Open
Conversation
Owner
|
Needs some work, but this sure is interesting. I'll have a closer look. |
Author
|
Great! Ya, feel free to point me in a better direction, particularly in terms of the js implementation, but I'd appreciate any other thoughts you might have. |
|
Will this get implemented into the plugin at all? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Wanted to put this here for your thoughts. A client project needed the ability to merge tags, instead of just renaming them. I thought it might be a useful feature for others since Craft allows tags to have the same string.
The merge implementation was straightforward thanks to a merge function on ElementsService. But I did have trouble getting the dropdown menu of tags to work as expected. The issue came down to the fact that I add tags to a list with jQuery when the menu is displayed. I couldn't find how to get Craft's click handlers to stick, and instead had to write my own.
I'd appreciate your thoughts on improvements, and if you think this is something you'd be interested in merging. Thanks!