make sure zlib data is always read as-is #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not allocating the filehandle at BUILD time means that a large number of G::PP::Pack objects can be thrown around without necessarily hitting a filehandle limit (as was encountered with Gitalist and a repo with a large numbers of refs).
make sure zlib data is always read as-is
… sha, preceded by '^' and no ref name, those mean that the listed sha is an alternative for the preceding ref name
… reason for this is that the commit SHA1 is stored second in packed-refs if a commit is annoted with a tag object.
A git object can also be of zero size.
fix for the retrieval of ref sha1s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.