Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ remove unused coduo/php-matcher dependency - issue #3551 #3558

Merged
merged 11 commits into from
Mar 13, 2025
Merged

⬆️ remove unused coduo/php-matcher dependency - issue #3551 #3558

merged 11 commits into from
Mar 13, 2025

Conversation

macintoshplus
Copy link
Contributor

The development dependency coduo/php-matcher is not used in code and lock the doctrine/orm update.

See issue #3551

@macintoshplus macintoshplus mentioned this pull request Mar 11, 2025
Open
19 tasks
@macintoshplus macintoshplus added the dependencies Pull requests that update a dependency file label Mar 11, 2025
bobvandevijver
bobvandevijver requested changes Mar 12, 2025
View reviewed changes
Copy link
Member

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still mentioned in the about

@macintoshplus
Copy link
Contributor Author

About removed

bobvandevijver
bobvandevijver requested changes Mar 12, 2025
View reviewed changes
Copy link
Member

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still failing.

@macintoshplus macintoshplus force-pushed the issue_3551_remove_coduo_php-matcher branch from ae78a13 to fa74e7b Compare March 12, 2025 08:14
@macintoshplus
Copy link
Contributor Author

Tests are still failing.

The API test faill with this error Associations with fetch-mode=EAGER may not be using WITH conditions in.

I have this error only with SQLite.

bobvandevijver
bobvandevijver requested changes Mar 12, 2025
View reviewed changes
@macintoshplus macintoshplus force-pushed the issue_3551_remove_coduo_php-matcher branch from 326ad57 to ea9b764 Compare March 12, 2025 20:27
@bobvandevijver bobvandevijver merged commit ee65b66 into master Mar 13, 2025
42 checks passed
@bobvandevijver bobvandevijver deleted the issue_3551_remove_coduo_php-matcher branch March 13, 2025 08:12
@bobvandevijver bobvandevijver mentioned this pull request Mar 13, 2025
Closed
@macintoshplus macintoshplus restored the issue_3551_remove_coduo_php-matcher branch March 13, 2025 09:52
@macintoshplus macintoshplus deleted the issue_3551_remove_coduo_php-matcher branch March 13, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvandevijver bobvandevijver bobvandevijver approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macintoshplus @bobvandevijver