Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE Plugin: fix deadlock in FOptickPlugin::StopCapture #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Snowball2012
Copy link

This PR fixes an issue described here: #170

Optick::Update acquires coreLock and then tries to acquire UpdateCriticalSection lock if the capture has been stopped, while FOptickPlugin::OnEndFrameRT locks UpdateCriticalSection first and then tries to acquire coreLock, which results in a deadlock.

The proposed solution is to acquire UpdateCriticalSection lock each time coreLock is about to be acquired

Acquire UpdateCriticalSection lock each time coreLock is about to be locked to avoid deadlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant