Alistair Henshaw#57
Open
Alistair1080 wants to merge 6 commits into
Open
Conversation
vherus
reviewed
Jun 18, 2024
Comment on lines
+11
to
+16
| date(date) { | ||
| if (typeof date !== "string") { | ||
| throw "date must be a string" | ||
| } | ||
| this.#date = date | ||
| } |
Contributor
There was a problem hiding this comment.
It doesn't look like this function is ever used outside of tests. Is it necessary? The function name isn't very descriptive, it's not clear what it does from the name alone
vherus
reviewed
Jun 18, 2024
| return this.#date | ||
| } | ||
| get loggedIn() { | ||
| return this.#loggedIn |
Contributor
There was a problem hiding this comment.
Try to name booleans like it's answering a yes / no question, e.g. isLoggedIn or hasSomething
vherus
reviewed
Jun 18, 2024
| this.#transactions = search.transactions | ||
| } | ||
| deposit(amount) { | ||
| if (this.#loggedIn === false) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.