Add [[maybe_unused]] to all inline variables#70
Merged
saki7 merged 1 commit intoboostorg:developfrom Oct 7, 2025
Merged
Conversation
saki7
added
the
upstream-workaround
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1
Follow-up for #68 and potentially many other PRs
Many inline variables, notably
inline constexprCPOs were introduced since the beginning of the C++23 modernization. GCC tends to report false-positive "unused variable" warnings for such entities. It has been problematic because the warnings were shown in a very unpredictable scenario; even I made sure no warnings were shown in the initial PR, the warnings were showing up after some irrelevant PRs were merged.This PR proactively adds
[[maybe_unused]]to all inline variables to prevent further bogus warnings.