Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1
cc: @yaito3014
The old implementation had unnecessary
class Contextparameter for many core traits, which were never being used since its very first introduction 12 years ago. We will not support such premature customization points in X4 and they were considered the contribution barrier for improving core components.The only remaining attributes in X4 that are deduced dynamically at parse time are the classes that are controlled by
traits::pseudo_attribute.traits::attribute_of: removed in favor ofparser_traits<Parser>::attribute_typetraits::has_attribute: removed in favor ofparser_traits<Parser>::has_attributetraits::attribute_type: removed; fusion ADT adapters will not be supported in X4traits::pseudo_attribute: moved tocore/attribute.hppstatic bool has_attribute = ...;: redundant definition removed from parsers, only the truly needed ones remainstatic bool handles_container = ...;: redundant definition removed from parsers, only the truly needed ones remainstatic bool is_pass_through_unary = true;: removed in favor ofstruct x4::proxy_parser